Both of the switch diagrams are probably ok. There is a whole check list for popping 3pdts, have you been through this before?
Have you read
http://www.muzique.com/lab/pop.htm? That site is pure poetry.
Are you testing this thing all alone, just the guitar>pedal>amp? Pedal ventriloquism is a thing...
Sometimes "stuff" gets microphonic. I've seen switches like this, ceramic caps.... just a tap on the enclosure can send a "bang" down the line.
Check for voltage at PCB in and out. Power on, best if the switch is not hooked up or the pull down(s) are not present. If there is a voltage DC on in or out, you have a leaky cap. You may, if the voltage is small, try a smaller pull down resistor. Won't hurt anything to tack solder another (and another) in parallel.
You may try disconnecting the LED and testing the bypass.